Aller au contenu
login
arrow_backRetour aux issues
gougoujiang/buildmax #127

`.gitattributes` credits a generator script the repository does not have

ecoDébutant documentation good first issue area: contributor-experience

descriptionDescription

## Page or file `.gitattributes`, line 28. ## What is stale The comment above the `NOTICE-THIRD-PARTY` rule reads: > Generated at release time by scripts/gen-third-party-notices.sh. There is no `scripts/` directory. `docs/contribute/repo-layout.md` line 66 says so outright — "There is no `scripts/` directory" — and explains that repository tooling lives in `cmd/mk` instead. The file is produced by `cmdNotices` in `cmd/mk/licenses.go`, reachable as `./make release notices`; its own comment still describes reproducing "what the shell script emitted", so the script existed once and the comment outlived it. Two contributor-facing statements about the same directory disagree, and the one in `.gitattributes` is the wrong one. ## What would help Point the comment at `./make release notices`. While there, `cmd/mk/licenses.go` line 24 mentions the shell script in the past tense — that one is accurate as history, so it can stay or be reworded, whichever reads better to you. ## Verify ```bash ls scripts # No such file or directory grep -rn "scripts/" .gitattributes ./make release notices --help # the real generator ```
codeOuvre sur GitHub